Evergreen 3.3 Missing Floating Group Configuration details Interface

Bug #1840287 reported by Christine Burns
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.3
Undecided
Unassigned
3.4
Medium
Unassigned

Bug Description

Evergreen 3.3

Admin -> Server Administration -> Floating Groups

This opens the Floating Group Configuration

You can add a new Floating Group, but there is no way to configure the linked group members.

Version 3.2.5 still has the OLD XUL interface - double clicking on the Floating Group name opens a new screen where you can add/edit the linked group members

Revision history for this message
Christine Burns (christine-burns) wrote :
tags: added: regression
Andrea Neiman (aneiman)
Changed in evergreen:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Medium
tags: added: angular
Mike Risher (mrisher)
Changed in evergreen:
assignee: nobody → Mike Risher (mrisher)
Revision history for this message
Mike Risher (mrisher) wrote :

I pushed a branch with these changes. It got fairly involved with 4 new files plus 5 files modified, so it could use a review before I submit a pull request.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=cd95dce1c442c7325d80ea043051877bace73476

Revision history for this message
Mike Risher (mrisher) wrote :

Thanks for the feedback. This is ready for another look.

I've made adjustments, such as creating a new floating groups module, putting the floating group files in their own directory, and cleaning up some code. I also made sure to confirm that the default new record works properly when creating multiple new entries consecutively.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=c86d8bb2806085784ec53655045c3643d5517fa3

Mike Risher (mrisher)
Changed in evergreen:
assignee: Mike Risher (mrisher) → nobody
Mike Risher (mrisher)
tags: added: pullrequest
Revision history for this message
Mike Risher (mrisher) wrote :

This has been rebased to master.

Revision history for this message
Bill Erickson (berick) wrote :

Mike, which working branch has the most recently rebased code?

Revision history for this message
Mike Risher (mrisher) wrote :
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Mike. The UI is looking great. I have reviewed your branch and pushed some additional commits:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1840287-convert-floating-groups

1. I signed off on your commit.

2. I pushed a commit to add 'required' attributes to floating group and member fields so form validation will work in the editor forms.

3. I pushed another commit with a mixed bag of features, bug fixes, formatting repairs (reminder to use 'ng lint'), and nice to haves (in hopes they will be informative). Here's a breakdown from the commit:

* Added grid sorting to both group and group member grids.

* Avoid using the defaultNewRecord in fm-editor directly, by cloning it as needed, so that subsequent new records (within a single parent component instance) do not pick up values from the previously created record.

* Renamed the eg-admin-page @Input() 'hideFields' to 'hideGridFields' to better explain how the value will be passed along.

* Replace access of fieldmapper innards (thing.a[0]) with field names (thing.id())

* Remove unused <eg-string /> entries.

* Avoid unnecessary newlines in translatable strings.

* Remove unused @Inputs() and unneeded functions

* Remove unused TreeModule import

* Removed a redundant <eg-title /> -- <eg-staff-banner /> will set the title when present.

* Various 'ng lint' repairs.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Jane Sandberg (sandbej) wrote :

Thanks, Mike and Bill. Here's a rebased branch with signoffs for your work on this: user/sandbergja/lp1840287-convert-floating-groups

I also added another small commit. It just adds a button to the floating group edit page that takes the user back to the list of all floating groups.

Revision history for this message
Felicia Beaudry (fbeaudry) wrote :

This also affects version 3.4.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Code merged to master.

I don't have a 3.4 system setup at the moment (older Angular version, etc.) to test, so instead I have pushed what should be a 3.4 (and theoretically 3.3) -compliant branch with sign-offs:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1840287-convert-floating-groups-3.4

Changed in evergreen:
milestone: none → 3.5-alpha
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
tags: added: signedoff
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers