Comment 2 for bug 1836808

Revision history for this message
Galen Charlton (gmc) wrote :

Thanks for the patch. I agree that there needs to be a way to abandon a record edit in that modal without having to close the entire modal.

I do have two suggestions:

[1] With your patch, if you close the inline editor, any edits you make are still visible if you edit the record again, which could be confusing to users. I suggest making the act of closing the inline editor also undo any unsaved changes to the record.

[2] In parallel with the above suggestion, I suggest changing the label of the new button to "Cancel Edit" or the like.