webstaff: Add "Close" button in Merge UI

Bug #1836808 reported by Kyle Huckins
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

Version: Latest evergreen master as of 7-16-2019

In the Merge Record UI, when editing a record via the "edit" button, there are only two ways to exist the MARC Edit UI: Closing the modal or saving your changes. It's not immediately clear that Saving will close the MARC Editor and bring you back to the regular MARC view. Ideally, we would have a close button adjacent to the "Edit" and "Edit with full editor" buttons, so you can close the Editor without saving your changes or closing the modal.

Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Kyle Huckins (khuckins)
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Mike Risher (mrisher)
Changed in evergreen:
assignee: nobody → Mike Risher (mrisher)
Revision history for this message
Mike Risher (mrisher) wrote :
Changed in evergreen:
assignee: Mike Risher (mrisher) → nobody
tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
status: New → Confirmed
assignee: nobody → Galen Charlton (gmc)
importance: Undecided → Medium
Revision history for this message
Galen Charlton (gmc) wrote :

Thanks for the patch. I agree that there needs to be a way to abandon a record edit in that modal without having to close the entire modal.

I do have two suggestions:

[1] With your patch, if you close the inline editor, any edits you make are still visible if you edit the record again, which could be confusing to users. I suggest making the act of closing the inline editor also undo any unsaved changes to the record.

[2] In parallel with the above suggestion, I suggest changing the label of the new button to "Cancel Edit" or the like.

tags: added: cataloging needsdiscussion
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Mike Risher (mrisher)
Changed in evergreen:
assignee: nobody → Mike Risher (mrisher)
Revision history for this message
Mike Risher (mrisher) wrote :

Thanks very much for catching those issues! I've resolved both and have changed my commit. https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=95009b320e30610b32f20f1f3911a5f8a8e840ee

Changed in evergreen:
assignee: Mike Risher (mrisher) → nobody
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Thanks for the update, Mike. I've signed off on the patch. The signoff branch is user/gmcharlt/lp1836808_signoff and also contains a commit adding release notes.

tags: removed: needsdiscussion
Changed in evergreen:
importance: Medium → Wishlist
milestone: none → 3.4-beta1
assignee: Galen Charlton (gmc) → nobody
Galen Charlton (gmc)
tags: added: signedoff
Revision history for this message
Galen Charlton (gmc) wrote :

Now pushed to master for inclusion in 3.4. Thanks, Mike!

Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers