webstaff: Add "Close" button in Merge UI

[Kyle Huckins]

Version: Latest evergreen master as of 7-16-2019

In the Merge Record UI, when editing a record via the "edit" button, there are only two ways to exist the MARC Edit UI: Closing the modal or saving your changes. It's not immediately clear that Saving will close the MARC Editor and bring you back to the regular MARC view. Ideally, we would have a close button adjacent to the "Edit" and "Edit with full editor" buttons, so you can close the Editor without saving your changes or closing the modal.

[Mike Risher (mrisher)]

I've pushed a branch:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=a3124fe1d30b3fd63bd48f9089a9380b98e90e87

[Galen Charlton (gmc)]

Thanks for the patch. I agree that there needs to be a way to abandon a record edit in that modal without having to close the entire modal.

I do have two suggestions:

[1] With your patch, if you close the inline editor, any edits you make are still visible if you edit the record again, which could be confusing to users. I suggest making the act of closing the inline editor also undo any unsaved changes to the record.

[2] In parallel with the above suggestion, I suggest changing the label of the new button to "Cancel Edit" or the like.

[Mike Risher (mrisher)]

Thanks very much for catching those issues! I've resolved both and have changed my commit. https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=95009b320e30610b32f20f1f3911a5f8a8e840ee

[Galen Charlton (gmc)]

Thanks for the update, Mike. I've signed off on the patch. The signoff branch is user/gmcharlt/lp1836808_signoff and also contains a commit adding release notes.

[Galen Charlton (gmc)]

Now pushed to master for inclusion in 3.4. Thanks, Mike!