Comment 4 for bug 1823981

I've reviewed the interface. It does the thing and will be a great improvement. I'm not quite ready to sign off, though, and have some comments:

- The p-3 class around the grantable and delete inputs adds too much padding IMO; p-1 looks better to me
- I'm not sure that we need the borders around the Grantable and Delete cells for inherited (and non-editable) permissions, on the theory that the borders are meant to highlight where the user can make change.
- It might be more clear to display the text "inherited" or the like for inherited permissions.
- The required permission drop-down ought to be sorted
- The color contrast is too low for
  - Apply Changes
  - Add New Mapping
  - red background of row selected for deletion
  - blue link text
  (not all of these originate from the patches for this bug, of course)
- Wishlist: it would be handy to be able to clone a permission group, by which I mean create a new one in the usual way and have permissions associated with its source be automatically copied over.