Port Permission Group Admin Page to Angular

[Bill Erickson]

Evergreen 3.3

Building atop bug #1823393 to take advantage of some of the changes there.

This bug tracks porting the Admin => Server Admin => Permission Groups page to Angular. This includes managing the group tree and the permissions linked to each group.

As a feature add-on, I'm adding support for displaying permissions linked to the selected group (which may be edited) while also filing in read-only views of inherited permissions for each group. The goal is to make it more obvious while editing if a group already has a permission via a parent group.

[Bill Erickson (berick)]

Code:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1823981-ang-perm-group-tree-admin

A few caveats...

1. Success/error toasts are not currently displaying as a result of a bug that is already fixed in the code for bug #1823367.

2. This code will need dialog refactoring once the code for bug #1823041 is merged.

[Bill Erickson (berick)]

Branch rebased to master amid commit flurry. This resolves the issue noted above about toasts not displaying.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1823981-ang-perm-group-tree-admin

[Bill Erickson (berick)]

Same branch as previous comment rebased to master to update the dialog/observable handling. Also, I added a filter feature to the group-linked permissions interface so the list of perms can be filtered by code / description.

[Galen Charlton (gmc)]

I've reviewed the interface. It does the thing and will be a great improvement. I'm not quite ready to sign off, though, and have some comments:

- The p-3 class around the grantable and delete inputs adds too much padding IMO; p-1 looks better to me
- I'm not sure that we need the borders around the Grantable and Delete cells for inherited (and non-editable) permissions, on the theory that the borders are meant to highlight where the user can make change.
- It might be more clear to display the text "inherited" or the like for inherited permissions.
- The required permission drop-down ought to be sorted
- The color contrast is too low for
  - Apply Changes
  - Add New Mapping
  - red background of row selected for deletion
  - blue link text
  (not all of these originate from the patches for this bug, of course)
- Wishlist: it would be handy to be able to clone a permission group, by which I mean create a new one in the usual way and have permissions associated with its source be automatically copied over.

[Bill Erickson (berick)]

Thanks, Galen. New branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1823981-ang-perm-group-tree-admin-2

Contains 2 commits:

I.

* Add a whiff of padding to the <eg-bool> component so the so there is some separation between the text and the badge border.

II.

* Loading progress now increments as data arrives.
* Application perm list is now sorted
* Deleted map now use warning background instead of danger as it appears to have better contrast.
* Inherited perms display the label 'Inherited' in the deleted column.
* Remove border boxes around non-actionable inherited values.
* Use Bootstrap button links instead of <a> for links to perm groups to improve contrast and consistency.

==

The "Apply Changes" and "New Mapping" buttons are stock Bootstrap. Presumably we'll need a more systemic solution to fixing those, as those types of buttons appear throughout. One option may be to make better use of outline buttons: https://getbootstrap.com/docs/4.3/components/buttons/#outline-buttons

I did not implement the Wishlist request. I'm considering moving that a new LP.

[Bill Erickson (berick)]

Oh, and the p-3 => p-1 padding changes are in there too.. forgot about those.

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.4. Thanks, Bill!