fields should be hidden when the relevant ".show" org unit setting is false

Bug #1815950 reported by a. bellenir on 2019-02-14
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

settings for field visibility,, for example, cannot be used to hide fields by setting their value to false.

i want to hide the prefix field from the patron editor, even when "All fields" is selected (we don't use it).

setting to false has no effect.
setting it to true will cause the field to show up when viewing "Suggested Fields" or "Required Fields".

irc discussion:

Changed in evergreen:
importance: Undecided → Wishlist
status: New → Confirmed
Jason Stephenson (jstephenson) wrote :

I agree with the description, but think this is a change in behavior and so not exactly a bug. I've confirmed this and set the importance to Wishlist as I think this would be a new feature or at least a change in behavior of an existing feature.

I think it also depends on whether or not you can unset a setting from the staff client once it has been set, i.e. can you delete an org_unit setting from an org unit via the client. I typically mess with these in the database where it is easy to delete them.

What I envision is the following: Setting the .show setting to true makes it show up for "All Fields," "Suggested Fields," and "Required Fields" as it currently does. Setting the .show setting to false will cause the field to not show up at all. Having the setting unset, it will only show up for "All Fields" as it currently does for unset or being set to a false value.

I also think the .suggested and .required settings should have precedence over .show, so that if either of those is true and the .show setting is false, then the .show setting behaves as if unset.

If anyone disagrees with this new behavior, please chime in.

a. bellenir (abellenir) wrote :
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers