Setting Library Setting Show county field on patron registration to False isn't honored

[Erica Rohlfs]

Originally noticed in EG version 3.4.3 and I just verified the same behavior in version 3.6.0

When setting Library Setting: Show county field on patron registration to the value of False, the County field remains on the patron registration screen (in all tab options: Required Fields, Suggested Fields, and All Fields).

[Jennifer Pringle (jpringle-u)]

Confirmed in 3.8.0. County continues to show in Required Fields, Suggested Fields, and All Fields when "Show county field on patron registration" is set to False.

[Jennifer Pringle (jpringle-u)]

Continues to be an issue in 3.9

[Jeff Davis (jdavis-sitka)]

It looks like any field with default_field_visibility = 2 in PatronRegCtl incorrectly behaves as if it were required, regardless of org unit settings.

Also, the get_org_settings function only looks up the ui.patron.edit.aua.county.require setting; it should probably retrieve .show as well. (There is no .suggest setting for county.)

[Jason Stephenson (jstephenson)]

I'm making this a duplicate of bug 1815950 because I intend to fix all of these issues with a followup to a. bellenir's patch on that bug.