Comment 10 for bug 1797934

Revision history for this message
Dan Wells (dbw2) wrote :

Thanks, Jane and Remington! I've pushed this to master, but with a few (ahem) reservations.

First, I think this tab should probably be optional. Many libraries do not use Bookings, and I feel that an empty "Reservations" tab in the OPAC may generate questions and confusion, especially for libraries (like us) using an external system for booking library resources.

Second, the service code may need a little refactoring. For example, the editor is already a friendly interface for CStore, so we can avoid the CStore connection. We also might be better served with a "search" method on the editor rather than a json_query, but that is certainly debatable. I'll open separate bugs in the next few days, but if anyone wants to jump on these ideas right here, please do so.