Ability to view booking reservations (reserved, captured, and out) in My Account in the OPAC

Bug #1797934 reported by Jane Sandberg on 2018-10-15
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

Currently, patrons can't confirm that their reservations are in place except by talking to a staff member. This limitation is mentioned on the Student Success Working Group's Booking Improvements page: https://wiki.evergreen-ils.org/doku.php?id=student_success_working_group:booking_improvements

Branch coming soon to add a Reservations tab to the OPAC that allows patrons a self-service way to check on their booking reservations.

Jane Sandberg (sandbej) on 2018-10-15
Changed in evergreen:
importance: Undecided → Wishlist
Jane Sandberg (sandbej) wrote :

I just created a branch called user/sandbergja/lp1797934_add_patrons_booking_reservations_to_the_OPAC

Here is a link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1797934_add_patrons_booking_reservations_to_the_OPAC

One note: this displays reservation dates/times using the pickup library's timezone. When testing, make sure that the pickup library actually has a timezone set (In Administration > Local Administration > Library Settings Editor) or the times will probably look very different than they do in the staff client.

Also note that this adds a new OpenSRF method called open-ils.booking.reservations.upcoming_reservation_list_by_user, so that patrons can view their own reservations without being stopped by permission issues. Testers may have to restart opensrf for the new method to show up.

What do you think?

tags: added: pullrequest
Jane Sandberg (sandbej) wrote :

Just a note that I'd forgotten about canceled reservations in my branch. I just pushed another commit to that branch that takes canceled reservations into account -- they still display, but with a status of "Canceled".

Jane Sandberg (sandbej) on 2018-12-30
Changed in evergreen:
milestone: none → 3.3-beta1
Jane Sandberg (sandbej) wrote :

Just a note that I pushed a small commit to that branch to catch some reservations that weren't previously appearing in the OPAC.

Hi Jane

I tested this using a local library and it worked as desired. When I tested with a library in a different timezone the reservation times do not display correctly in the OPAC.

I checked that setting (Administration > Local Administration > Library Settings Editor > Library time zone) is set.

In the staff client my reservation shows pickup 11:07 am, in the OPAC it shows 9:07am

Changed in evergreen:
status: New → Confirmed
Jane Sandberg (sandbej) wrote :

Thanks for your testing here, Christine. I'll give this a look.

tags: removed: pullrequest
Jane Sandberg (sandbej) wrote :

...and to confirm my thinking: the OPAC should always display reservation-related times using the pickup library's timezone, correct?

Thanks Jane

Yes this is correct - the OPAC should always display reservation-related times using the pickup library's timezone, correct?

Jane Sandberg (sandbej) wrote :

Okay, I believe I fixed this, as well as removing some test code. Here's an updated branch: user/sandbergja/lp1797934_add_patrons_booking_reservations_to_the_OPAC_tz_fixed

tags: added: pullrequest
Remington Steed (rjs7) wrote :

I tested this, and it works! Here's my signoff branch, with one new commit that makes minor changes to the table heading labels.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1797934_booking_reservations_on_OPAC

Dan Wells (dbw2) on 2019-02-20
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Dan Wells (dbw2) wrote :

Thanks, Jane and Remington! I've pushed this to master, but with a few (ahem) reservations.

First, I think this tab should probably be optional. Many libraries do not use Bookings, and I feel that an empty "Reservations" tab in the OPAC may generate questions and confusion, especially for libraries (like us) using an external system for booking library resources.

Second, the service code may need a little refactoring. For example, the editor is already a friendly interface for CStore, so we can avoid the CStore connection. We also might be better served with a "search" method on the editor rather than a json_query, but that is certainly debatable. I'll open separate bugs in the next few days, but if anyone wants to jump on these ideas right here, please do so.

Changed in evergreen:
status: Confirmed → Fix Committed

I agree with Dan that the reservations tab should be optional.

In Sitka we only have a few libraries that use Booking so we would need to be able to set it per library.

Jane Sandberg (sandbej) wrote :

I can look at making this optional. I would think that parts/config.tt2 would be a good place to turn this on and off. From this thread, it seems that the default should probably be off?

Jane Sandberg (sandbej) wrote :

Here's a pretty simple branch to make this optional: user/sandbergja/lp1797934_opac_reservations_tab_optional

Thank you Jane!!!!

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: Fix Committed → Fix Released
Dan Wells (dbw2) on 2019-03-06
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Dan Wells (dbw2) wrote :

Finally got around to pulling in the optionality commit; works fine. Thanks, Jane.

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers