Web Client - Copy Templates - Floating drop down is broken

[Christine Burns]

EG 3.0.3

Admin->Local Admin->Volume/Copy Template Editor
or
Retrieve copy->Edit Items->Copy Templates

In the copy template editor the "Floating" drop down menu is broken. [no entries display but entries do exist]

The "Floating" drop down menu in the copy editor works as expected.

I have included a .jpg which shows examples of the Floating drop down in the copy editor (Good) and the Floating drop down in the copy template editor (Bad)

[Elaine Hardy (ehardy)]

We see a problem with the menu in copy editor as well. See https://bugs.launchpad.net/evergreen/+bug/1744080

[Janet Schrader (jschrader)]

This is true for CMARS also so floating selection cannot be added to templates.

[Kyle Huckins (khuckins)]

I've pushed up a branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1759327-volcopy-populate-floating-dropdown

The issue ended up being that while the information existed in the parent scope, a function call wasn't being made in the directive for eg-vol-template. After adding it, everything appears to work as expected.

[Jeanette Lundgren (jlundgren)]

Added branch to 3.0.7 test server.

Admin->Local Admin->Volume/Copy Template Editor

After patch the floating drop down now opens and the entries display (see image attached). The floating field now works the same as the copy editor.

Thanks Kyle!

I have tested this code and consent to signing off on it with my name, Jeanette Lundgren and my email address, <email address hidden>.

[Jason Stephenson (jstephenson)]

One thing I've noticed with this branch applied is that once you choose a floating value for the template and save the template, you cannot later remove the floating value. That is, if a floating value is selected, then no blank entry appears in the drop down and only existing floating values can be chosen.

I don't know if that is a problem or not, but I think it is worth mentioning in case others consider it to be a problem.

[Christine Burns (christine-burns)]

see related bug - https://bugs.launchpad.net/evergreen/+bug/1749996

[Kyle Huckins (khuckins)]

I should note that without the branch, making a selection on floating when you've retrieved a copy functions in the same way, with no blank selection available after making a selection. It may be worth adding a blank option on the tt2 if anyone considers it an issue.

[Jeanette Lundgren (jlundgren)]

pushed signoff branch to http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jlundgren/lp1759327-signoff

[Jeanette Lundgren (jlundgren)]

It looks like there is a pullrequest on the related bug (copy editor - add remove floating option) that essentially adds a blank value, but drop down option says remove floating.

It would be good to apply consistent behavior here in the copy template editor. Kyle is this easily done?

[Jason Stephenson (jstephenson)]

Jeanette,

It would be trivial to add a similar option. My question was if it was desirable. Since it sounds like it is, I can add it if Kyle is busy on other things. I'll make a similar change to what was done by Jeff Davis on bug 1749996 and put these on my test vm for bug squashing week.

Jason

[Jason Stephenson (jstephenson)]

Actually, it looks like the combination of Jeff Davis' branch on bug 1749996 and this branch will resolve the whole thing and there is no need to make changes to this branch. I'll take that approach before attempting any changes, myself.

[Christine Burns (christine-burns)]

We have tested a combination of these two bugs fixes and I can confirm they resolve all issues.

Thanks everyone!!

[Elaine Hardy (ehardy)]

It is definitely desirable to be able to remove a floating option once set in the drop down menu. It could be set in error or the floating relationship could end.

[Janet Schrader (jschrader)]

I agree with Elaine that there needs to the ability to remove a floating option. I think the ability to remove an option should also be available for "Age-based hold protection", "Loan duration", and "Fine level" too. If one of these is accidentally chosen there is no way to remove it. "Circulation modifier" has the option of <NONE> so why not these four other fields.

[Jason Stephenson (jstephenson)]

I have tested Kyle's branch also with Jeff Davis' branch on bug 1749996, and the issues with the floating group in copy templates are resolved for me. I have pushed Kyle's branch to master, rel_3_1, and rel_3_0.

I will make a new bug based on Janet's comments in comment #15.

Thanks, everyone!