Comment 8 for bug 1746360

Revision history for this message
Remington Steed (rjs7) wrote :

Terran, thanks for your work on this! Your code change looks good to me. Two questions:

1. Your commit sign-off is missing your first name (it just says "Signed-off-by: McCanna ..."). Was that intended?

2. I also see the quotes around Edition when using your code. But when I enable the Edition column in the Patron Items Out screen, I don't see any quotes around it there. The JS for that screen fetches that data explicitly (rather than letting the grid auto-fetch it) and I notice the following code, which might be stripping the quotes. I'm not sure how to manipulate data that the grid auto-fetches. This is where I'd start asking Bill or others for help. :-)

staff/circ/patron/items_out.js:130
----------------------------------
// Translate bib display field JSON blobs to JS.
// Collapse multi/array fields down to comma-separated strings.
egBibDisplay.mwdeJSONToJS(
  circ.target_copy().call_number().record().wide_display_entry(), true);