Comment 2 for bug 1746098

Hmm, how do we handle changing pickup locations between a location that needs sms_carrier and one that doesn't. Or rather between a location that doesn't require sms_carrier and one that does. I guess the trigger could re-enter the default sms_carrier setting if switching, otherwize just remove sms_notify for that hold. Switching pickup lib does happen, but usually by accident and not very often in my experience.

Right now I'm thinking that it might be easier to replace the consistency check with a trigger that just removes the sms_phone if an update changes the pickup lib to a pickup_lib that doesn't support sms.hide_carrier.

But then I guess showing/hiding the sms_carrier field would need to be done based on the pickup location drop down and not the current search lib.

In our case no one in our consortium will still be using the email->sms method, so no one needs it, but that most likely won't be the case for everyone.

Josh