SMS - Hide Carrier Selection Preference
Bug #1746098 reported by
Josh Stompro
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
New
|
Undecided
|
Unassigned |
Bug Description
When using an SMS reactor that doesn't require a carrier (bug #1667080) for sending SMS hold pickup messages the opac.default_
I think that adding a new library setting that will go along with the current 'sms.enable' would be a reasonable way to do this. 'sms.hide_carrier'.
Besides adding a check for that pref to a few forms, I think that the hold/sms validation code might need to be adjusted. Bug 1098685.
Josh
tags: | added: actiontrigger circ-holds orgunitsettings |
To post a comment you must log in.
I started looking at this and found that right now an SMS carrier is required to place a hold due to a DB consistency check. If sms_phone is not null then sms_carrier must be not null.
So I'm wondering if I should go down the route of relaxing that consistency check, or should I just pick a carrier id and send that with the hold to minimize the scope of the change.
Here is what I have so far that either uses the default_carrier or picks the first one in the hash.
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ stompro/ lp1746098_ hide_sms_ carrier
Josh