I started looking at this and found that right now an SMS carrier is required to place a hold due to a DB consistency check. If sms_phone is not null then sms_carrier must be not null.
So I'm wondering if I should go down the route of relaxing that consistency check, or should I just pick a carrier id and send that with the hold to minimize the scope of the change.
Here is what I have so far that either uses the default_carrier or picks the first one in the hash.
I started looking at this and found that right now an SMS carrier is required to place a hold due to a DB consistency check. If sms_phone is not null then sms_carrier must be not null.
So I'm wondering if I should go down the route of relaxing that consistency check, or should I just pick a carrier id and send that with the hold to minimize the scope of the change.
Here is what I have so far that either uses the default_carrier or picks the first one in the hash.
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ stompro/ lp1746098_ hide_sms_ carrier
Josh