1. Make approval code a required field in the cc payment form.
2. Prevents the payment code from continuing any further when the payment API fails.
#2 should help in other cases where printing occurs regardless of a payment failure (bug #1746830), though it's not clear it will resolve all cases, since they are not yet reproducible.
I have pushed some fixes here:
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ berick/ lp1743262- ecom-appr- code-required
The branch does 2 basic things:
1. Make approval code a required field in the cc payment form.
2. Prevents the payment code from continuing any further when the payment API fails.
#2 should help in other cases where printing occurs regardless of a payment failure (bug #1746830), though it's not clear it will resolve all cases, since they are not yet reproducible.