Web Client: Recording credit card payment fails without approval code

[Terran McCanna]

Likely related to:
https://bugs.launchpad.net/evergreen/+bug/1622696

In 3.0.2:

When choosing the option to "Record externally processed payment", approval code does not indicate it is required.

Entering an approval code processes normal in both Firefox and Chrome.

Submitting without an approval code in Firefox shows BAD_PARAM alert and returns user to bills screen. (The alert is confusing for users, but at least the users knows something was wrong.) No receipt is printed.

Submitting without an approval code in Chrome shows BAD_PARAM alert but then prints a receipt showing that the patron paid the bill even though the system has not recorded a bill payment.

[Bill Erickson (berick)]

I have pushed some fixes here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1743262-ecom-appr-code-required

The branch does 2 basic things:

1. Make approval code a required field in the cc payment form.
2. Prevents the payment code from continuing any further when the payment API fails.

#2 should help in other cases where printing occurs regardless of a payment failure (bug #1746830), though it's not clear it will resolve all cases, since they are not yet reproducible.

[Terran McCanna (tmccanna)]

Thanks so much, Bill!

I have tested this code and consent to signing off on it with my name, Terran McCanna and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed to master and rel_3_0, along with a follow-up patch to disable the submit button if the approval code is not supplied. Thanks, Bill and Terran!