Comment 6 for bug 1708291

Revision history for this message
Dan Wells (dbw2) wrote :

Okay, nevermind, I am going to let this stew a bit more. For the record, my (small) concern is the new option 'include_base_issuance' in the MFHD.pm, as it clashes in API naming with the 'base_holding' option for the same sub. I've tried to keep the MFHD side of things independent of Evergreen-isms (with a someday dream of making it a separate Perl module), so the simple solution would be to rename the option to 'include_base_holding' and call it a day. (I've also got no problem keeping the 'include_base_issuance' name in the Evergeen API up the stack, as it obviously makes the most sense there.)

*However*, upon further thought, it might make the most sense to just prepend this holding/issuance on the Evergreen side, and not force it down-and-back on the MFHD side at all. I'll open a separate bug for that if it ends up making working out as I am imagining it.

So, closing this bug out. Thanks again!