webstaff: serials module

Bug #1708291 reported by Galen Charlton on 2017-08-02
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

This is an enhancement bug for the web staff client's implementation of the serials module, which is an Angular rewrite that combines ideas from the XUL serials control view and alternate serials control view. In addition to porting existing functionality, some additional improvements are included:

* prediction pattern templates that can be shared and reused
* streamlined interface for managing subscriptions, distributions, and streams
* fixes for various long-standing bugs

Galen Charlton (gmc) on 2017-08-02
Changed in evergreen:
milestone: none → 3.0-alpha
importance: Undecided → Wishlist
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

A branch implementing the new serials module is available as collab/gmcharlt/lp1708291-webstaff-serials in the working/Evergreen repository:



This branch includes patches for a couple related bugs:

bug 1152753: make it possible for serial units to be added to copy bucket
bug 1682609: upgrade to angular-ui-bootstrap 1.3.3

tags: added: pullrequest serials
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Galen Charlton (gmc) wrote :

I pushed a small follow-up patch from Jason to the top of the working branch. There may be a couple more coming, but they won't materially affect the functionality, and it can be considered stable for anybody reviewing it.

Dan Wells (dbw2) on 2017-08-08
Changed in evergreen:
assignee: nobody → Dan Wells (dbw2)
Galen Charlton (gmc) wrote :

I've force-pushed a rebased version to the branch. Also, the branch now includes a commit with a tweak to the subscription selector: When entering the Manage Predictions or Manage Issues tab
and only one subscription is present in the current OU scope, automatically select it rather than making the operator have to select it manually.

Kathy Lussier (klussier) wrote :

I worked with some serials librarians to test this branch on webby earlier this summer. I loaded it on my own VM today and found that it works just as well as it did a couple of months ago. Actually, with Galen's most recent commit, it's even better.

Since I know Dan and Remington are also looking at it, I didn't merge the branch to master, but I can do so if they end up being crunched for time.

I added my signoff to a working branch at:

The above signoff branch also removes the commit that was included when the offline branch was merged to master and resolves merge conflicts in staff/services/ui.js, staff/base_js.tt2 and staff/Gruntfile.js.

Dan Wells (dbw2) wrote :

I built fresh again and tested from Kathy's sign-off branch, and things look really good. This is such a gigantic step forward, and I am looking forward to working with this in the near future! Thank you to everyone who helped design, test, fund, code, and overall make this a reality.

I have one very tiny follow up commit which I hope can be indulged (just a code-level name change in the MFHD module). Will push a branch shortly.

Dan Wells (dbw2) wrote :

Okay, nevermind, I am going to let this stew a bit more. For the record, my (small) concern is the new option 'include_base_issuance' in the MFHD.pm, as it clashes in API naming with the 'base_holding' option for the same sub. I've tried to keep the MFHD side of things independent of Evergreen-isms (with a someday dream of making it a separate Perl module), so the simple solution would be to rename the option to 'include_base_holding' and call it a day. (I've also got no problem keeping the 'include_base_issuance' name in the Evergeen API up the stack, as it obviously makes the most sense there.)

*However*, upon further thought, it might make the most sense to just prepend this holding/issuance on the Evergreen side, and not force it down-and-back on the MFHD side at all. I'll open a separate bug for that if it ends up making working out as I am imagining it.

So, closing this bug out. Thanks again!

Changed in evergreen:
assignee: Dan Wells (dbw2) → nobody
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers