Comment 3 for bug 1685929

Hi Kathy,

Thanks. Yeah I was hoping for a bit more feedback, both from technical and the user/circulation side.
Tina's workflow diagram is pretty good but it does have some gotchas/assumptions that will need to be discussed a bit further.

This task, or my patch for it at least, is already a large enough change to require a fair bit of testing, as I had to do some refactoring to keep the code DRY and make a lot of the check-in grid actions work (via the extracted/shared angular item service).

So, yea, I think it's probably best for this task to get a review/merge as it stands, and not spill over the original intent/scope of it which was just to add some of the actions lacking in the Webstaff's CheckIn grid, with the hairiness of missing pieces. Let's deal with details of missing pieces on bug 1257910.