Comment 2 for bug 1668734

Revision history for this message
Remington Steed (rjs7) wrote :

Terran, I just looked over your branch (I haven't tested it though), and I think it looks mostly right. One small problem I see is that instead of using an explicit upgrade script number, you should just use "XXXX" (both in the filename and in the "SELECT evergreen.upgrade_deps_block_check(..." line). The committer will fill in whatever the next number is when it's committed.

Also, there is a minor problem with your release notes entry. The header underline ("^^^^") needs to be the same length as the header text.

Besides those small issues, I think you have all the right pieces.