Wish List - New action trigger for SMS Preminder

Bug #1668734 reported by Terran McCanna on 2017-02-28
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

We developed an action trigger to send out SMS texts 3 days prior to an item's due date.

I'm working on getting it into the correct format to submit, and I'll make it disabled by default.

Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Remington Steed (rjs7) wrote :

Terran, I just looked over your branch (I haven't tested it though), and I think it looks mostly right. One small problem I see is that instead of using an explicit upgrade script number, you should just use "XXXX" (both in the filename and in the "SELECT evergreen.upgrade_deps_block_check(..." line). The committer will fill in whatever the next number is when it's committed.

Also, there is a minor problem with your release notes entry. The header underline ("^^^^") needs to be the same length as the header text.

Besides those small issues, I think you have all the right pieces.

Terran McCanna (tmccanna) wrote :

Thank you, Remington! I'll work on the corrections.

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Chris Sharp (chrissharp123) wrote :

Signoff branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1668734_sms_preminder_action_trigger

Though we try as a rule to have people from different organizations do the signoffs on each other's patches, factoring in Remington's feedback and the fact that we have been running this code in PINES production for several months, I think we're good.

tags: added: signedoff
Galen Charlton (gmc) on 2017-08-28
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

Pushed to master, along with a couple tweaks. Thanks, Terran and Chris!

Changed in evergreen:
status: New → Fix Committed
milestone: none → 3.0-alpha
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers