While the checkin UI's option was called "suppress_popups," the service was looking for "suppress_checkin_popups," but only on certain cases. I've expanded its reach a bit, and changed the references in the service to match the controller.
I also noticed that the option does not exist at all in the patron items out UI, where checkins can also be performed. Is this expected?
I've pushed a branch here that should resolve the issue for the checkin UI: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ khuckins/ lp1437103- suppress- popups- on-checkin
While the checkin UI's option was called "suppress_popups," the service was looking for "suppress_ checkin_ popups, " but only on certain cases. I've expanded its reach a bit, and changed the references in the service to match the controller.
I also noticed that the option does not exist at all in the patron items out UI, where checkins can also be performed. Is this expected?