unexpected popup dialogs appear at checkin

[Sally Fortin]

It appears that the OU setting to suppress popup dialogs during checkin is not being honored. I received pop-ups for items put in transit and for checkin of missing and lost items when the OU setting was set to suppress them.

[Victoria Lewis (vlewis-q)]

Do we want to see a transit slip pop-up during checkin of a book with a hold?

[Bill Erickson (berick)]

Victoria, I think in this case there is no difference between a hold transit alert and a non-hold transit alert. They should both be suppressed.

Note that circ/services/circ.js already has a suppress_checkin_popups option and the checkin code is setting it to true when appropriate. It just needs to be taught how to suppress a few more alert types.

[Victoria Lewis (vlewis-q)]

Add code to suppress popups on checkin.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/lp1437103-unexpected_popup_dialogues_at_checkin

[Mike Rylander (mrylander)]

I'm not sure of the purpose of the suppress_checkin_popups value in the options object. It doesn't seem to be used by the patch, or other code in the controller. To avoid confusion, if it's not used, it should be removed.

Thanks!

[Victoria Lewis (vlewis-q)]

The suppress_checkin_popups value in the options object in Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js prevents a popup dialog when checking in media via the patron screen that has been flagged as lost.

The suppress_checkin_popups value in the options object in Open-ILS/web/js/ui/default/staff/circ/checkin/app.js prevents a popup dialog when checking in media via Nav Bar -> Circulation -> Check In that has been flagged as lost.

[Jeremiah Miller (jeremym-t)]

Trying to move to the web client, this is showstopper territory.

We use RFID here. At one branch that doesn't have an automated sorting/checkin system, we checkin multiple items at once... large handfuls on the RFID pads. Goes very quickly.

Popups for individual items continually interrupting entire stacks of checkins completely ruins that workflow. The XUL client has no such issue.

As a side note, we've found that if we disable Transit Slips and Hold Slips in "Auto-Print Settings", we can prevent the popups... but only if we also disable "Checkout Receipts". Which we can't do, we need those.

[Kyle Huckins (khuckins)]

I've pushed a branch here that should resolve the issue for the checkin UI: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1437103-suppress-popups-on-checkin

While the checkin UI's option was called "suppress_popups," the service was looking for "suppress_checkin_popups," but only on certain cases. I've expanded its reach a bit, and changed the references in the service to match the controller.

I also noticed that the option does not exist at all in the patron items out UI, where checkins can also be performed. Is this expected?

[Kyle Huckins (khuckins)]

After some discussion, I've pushed up a commit on top of the previous one to ensure the Patron Items Out UI respects this setting as well.

[Kyle Huckins (khuckins)]

Another small update, an issue was discovered where the route dialog function was being prematurely ended by one of the suppress popup checks. I've pushed an additional commit to allow transit receipts to print in this scenario.

[Bill Erickson (berick)]

Issue and fixes confirmed. I tested both the checkin page and the patron Items Out page.

Thanks, All! Merged to 3.3 and up.