Comment 1 for bug 1064651

Revision history for this message
James Fournie (jfournie) wrote :

It looks like test_and_create_hold_batch() is calling a separate method, open-ils.circ.title_hold.is_possible. That method captures the hold boundary from the settings and returns it, however it looks like test_and_create_hold_batch doesn't pay much heed as to what title_hold.is_possible returns at all, and instead just passes the same parameters it passes into title_hold.is_possible into open-ils.circ.holds.create. It's a reasonable assumption that title_hold.is_possible doesn't enrich the hold request, but unfortunately it does.

I have a fix to be pushed to user/jamesrf/lp1064651_selection_depth_fix. This fix is critical for Sitka in order to use the TPAC in the staff client -- without it, copies outside of boundaries will be targetted, which causes confusion for patrons and libraries.

However, the fix is not ideal, it simply makes test_and_create_hold_batch() check for and use the value returned by title_hold.is_possible, some code refactoring is probably needed.