TPAC > Hold doesn't save selection_depth
Bug #1064651 reported by
Steve Callender
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.2 |
Fix Released
|
Undecided
|
Unassigned | ||
2.3 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I tested this in 2.2.2 TPAC.
In sub test_and_
Looks like the depth needs to be specified i the subroutine.
Changed in evergreen: | |
status: | New → Triaged |
Changed in evergreen: | |
status: | In Progress → Fix Committed |
milestone: | none → 2.4.0-alpha |
assignee: | Jason Stephenson (jstephenson) → nobody |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
It looks like test_and_ create_ hold_batch( ) is calling a separate method, open-ils. circ.title_ hold.is_ possible. That method captures the hold boundary from the settings and returns it, however it looks like test_and_ create_ hold_batch doesn't pay much heed as to what title_hold. is_possible returns at all, and instead just passes the same parameters it passes into title_hold. is_possible into open-ils. circ.holds. create. It's a reasonable assumption that title_hold. is_possible doesn't enrich the hold request, but unfortunately it does.
I have a fix to be pushed to user/jamesrf/ lp1064651_ selection_ depth_fix. This fix is critical for Sitka in order to use the TPAC in the staff client -- without it, copies outside of boundaries will be targetted, which causes confusion for patrons and libraries.
However, the fix is not ideal, it simply makes test_and_ create_ hold_batch( ) check for and use the value returned by title_hold. is_possible, some code refactoring is probably needed.