Comment 8 for bug 1037171

Hi Liam,

This looks really good. I have one nit.

By clearing all of stop_parms from the advanced search link, if you do an advanced search, look at the results, then click the advanced search link with an aim of refining your search terms further, you now find that all those terms are cleared, which may not be desirable.

If you agree, I think in the last hunk of your patches you just want the last parameter to mkurl to be expert_search_parms rather than general_search_parms.merge(expert_search_parms).

Thanks!