Comment 2 for bug 395464

Revision history for this message
Sulan (sulan80) wrote :

Actually i think it should look more like this:

addParam(sev==SEV_SUCCESS ? "000" : Util::toString(sev * 100 + err));

Protocol states:
 Success (used for confirming commands), error code must be "00", and an additional flag "FC" contains the FOURCC of the command being confirmed if applicable.

sev == 0 should always have err == 0, thus no need to consider err when sev==0. Also your way would make 010 to be 10.