Successful status code is badly formatted for STA command

[eMTee]

From the protocol :
Status code in the form "xyy" where x specifies severity and yy the specific error code.
0 Success (used for confirming commands), error code must be "00",

This solution is from StrongDC++ so if its accepted, it must be credited to BigMuscle.

[Sulan (sulan80)]

Actually i think it should look more like this:

addParam(sev==SEV_SUCCESS ? "000" : Util::toString(sev * 100 + err));

Protocol states:
 Success (used for confirming commands), error code must be "00", and an additional flag "FC" contains the FOURCC of the command being confirmed if applicable.

sev == 0 should always have err == 0, thus no need to consider err when sev==0. Also your way would make 010 to be 10.

[poy (poy)]

Sulan's way seems fine (with parenthesis around sev==SEV_SUCCESS).

these success codes are only used by DC++ when initiating transfers, to send the referrer string; that is quite important, so please verify before checking in that referrers and connections aren't altered.

[eMTee (realprogger)]

No problem reported with StrongDC++ 2.30 and onwards for 15 months...
http://strongdc.svn.sourceforge.net/viewvc/strongdc/tags/strongdc-2.30/client/AdcCommand.cpp?revision=459&view=markup

[poy (poy)]

Fixed in DC++ 0.780.