Upgrade Dialog Should Only Be Persistent If Necessary

[goto]

Recently I reported this bug: https://bugs.launchpad.net/dcplusplus/+bug/344833 . This was resolved as wont fix.

The argument against is that new versions of DC++ introduces new network features. If people keep using old versions of DC++, they are holding back the network. My suggestion is to only show the upgrade dialog every time when the user is currently using a client that holds back the network. If the older version the user is using does not affect the network in a negative way, the user should be able to disable the upgrade dialog until the next upgrade of DC++ is available.

Also, most people do not understand or read the text presented on the upgrade dialog. Just "Do you want to upgrade?" is way more effective.

[eMTee (realprogger)]

We still don't agree with you so DC++ will always present an upgrade dialog box, but a discussion about this topic concluded that it may better to do it less frequently. With this patch proposal we use the ApexDC++ way so the nag screen appears only once every 3 days.
Also the dialog box message will be more clear what the dialog wants, with the first line of the message in the box is constant and translated in the localized versions.

[Toast (swetoast-deactivatedaccount)]

im all for this

[poy (poy)]

the OP's proposed distinction looks great to me - one shouldn't be forced to upgrade if the new version only improves on petty GUI features / docs. however, looking back through the last few years, i can't see any version that hasn't had stability fixes as well.

the patch or the initial suggestion (no immediate dialog - just a status bar message and a menu command) could be fine if it were limited to those versions without crash / security fixes; but for the current ones, which all contained these important fixes, always showing the dialog is a must.

as for reducing the amount of text presented in the upgrade dialog, i believe the current summary is far better than just "Do you want to upgrade?" - those who don't want to read it can skip it; others may find it useful.

[eMTee (realprogger)]

I really support always showing the dialog, the above was a try to make a good compromise between the always, sometimes, and never show (like eg. in BCDC++).
And let me remind you that because of using Coral cache by default, many users get the upgrade reminder several days later than it was uploaded so I think the 3 days interval isn't much worse than the current way.

Anyway as an option, we can add a Severity parameter to the Message node in version.xml which can regulate the nag window's behaviour between noshow, 3 days interval and always....

[iceman50 (bdcdevel)]

Even with a severity parameter I don't there should ever be a "No show" ... what about doing a check that is users settable i.e (they can set to check for an update every day all the way to every 7 days or something similar)

[poy (poy)]

a 3 days interval seems really artificial and doesn't fit well in any of the following categories:

- important update -> keep nagging to make sure the update is eventually applied.

- unimportant update -> status bar message / unintrusive button somewhere.

[eMTee (realprogger)]

If we want to make these choices then really not.

The proposal wasn't for fullfilling the request of the reporter, its a compromise result of some devs' opinions in the discussion of this report (who took time to discuss this report upon my 'daily unanswered bug' campaign).

Again, I generally don't support any hiding of the upgrade nag, but I can accept that a situation when someone doesn't want to upgrade right away, only sometime later, just want to use DC++, setup, several restarts, etc... in this case the nag screen can be annoying and totally unnecessary.