commit 37e4a12652c803d60c18079b735d96e5c7890f07
Author: John Griffith <email address hidden>
Date: Tue Nov 4 23:34:28 2014 +0100
Remove test_barbican from keymgr tests
Unfortunately it seems we have some very poorly
written keymgr unit tests, specifically
keymgr/test_barbican.py does this:
from barbicanclient.common import auth
First problem is that from a unit test perspective
that pretty much sucks, second problem is that
barbicanclient as of version 3.0.0.0 no longer
has an "auth" module, as a result Cinderunit tests
now fail.
The test_barbican.py unit tests need to be rewritten
to mock out the client components and actually test
Cinder components where needed without relying on
the barbicanclient.
For now in order to free up the gate, remove test_barbican.py
Reviewed: https:/ /review. openstack. org/132734 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=37e4a12652c 803d60c18079b73 5d96e5c7890f07
Committed: https:/
Submitter: Jenkins
Branch: master
commit 37e4a12652c803d 60c18079b735d96 e5c7890f07
Author: John Griffith <email address hidden>
Date: Tue Nov 4 23:34:28 2014 +0100
Remove test_barbican from keymgr tests
Unfortunately it seems we have some very poorly test_barbican. py does this: common import auth
written keymgr unit tests, specifically
keymgr/
from barbicanclient.
First problem is that from a unit test perspective
that pretty much sucks, second problem is that
barbicanclient as of version 3.0.0.0 no longer
has an "auth" module, as a result Cinderunit tests
now fail.
The test_barbican.py unit tests need to be rewritten
to mock out the client components and actually test
Cinder components where needed without relying on
the barbicanclient.
For now in order to free up the gate, remove test_barbican.py
Change-Id: Id770c87c0d622a e4c1e0d71141ffa 9aed29be2ec
Partial-Bug: #1389419