barbican tests import modules directly from barbican client but modules no longer exist

Bug #1389419 reported by John Griffith
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
In Progress
Critical
John Griffith
Juno
Fix Committed
Undecided
Unassigned

Bug Description

Unfortunately it seems we have some very poorly written keymgr unit tests, specifically keymgr/test_barbican.py does this:
    from barbicanclient.common import auth

First problem is that from a unit test perspective that pretty much sucks, second problem is that barbicanclient as of version 3.0.0.0 no longer has an "auth" module, as a result Cinder unit tests now fail.

The test_barbican.py unit tests need to be rewritten to mock out the client components and actually test Cinder components where needed without relying on the barbicanclient.

Changed in cinder:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → John Griffith (john-griffith)
Revision history for this message
John Griffith (john-griffith) wrote :

Temporarily remove test_barbican

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/132734

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/132734
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=37e4a12652c803d60c18079b735d96e5c7890f07
Submitter: Jenkins
Branch: master

commit 37e4a12652c803d60c18079b735d96e5c7890f07
Author: John Griffith <email address hidden>
Date: Tue Nov 4 23:34:28 2014 +0100

    Remove test_barbican from keymgr tests

    Unfortunately it seems we have some very poorly
    written keymgr unit tests, specifically
    keymgr/test_barbican.py does this:
    from barbicanclient.common import auth

    First problem is that from a unit test perspective
    that pretty much sucks, second problem is that
    barbicanclient as of version 3.0.0.0 no longer
    has an "auth" module, as a result Cinderunit tests
    now fail.

    The test_barbican.py unit tests need to be rewritten
    to mock out the client components and actually test
    Cinder components where needed without relying on
    the barbicanclient.

    For now in order to free up the gate, remove test_barbican.py

    Change-Id: Id770c87c0d622ae4c1e0d71141ffa9aed29be2ec
    Partial-Bug: #1389419

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/132821

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/juno)

Reviewed: https://review.openstack.org/132821
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=67c5a66cfc91febf13d8fbf1449641865fb059b0
Submitter: Jenkins
Branch: stable/juno

commit 67c5a66cfc91febf13d8fbf1449641865fb059b0
Author: John Griffith <email address hidden>
Date: Tue Nov 4 23:34:28 2014 +0100

    Remove test_barbican from keymgr tests

    Unfortunately it seems we have some very poorly
    written keymgr unit tests, specifically
    keymgr/test_barbican.py does this:
    from barbicanclient.common import auth

    First problem is that from a unit test perspective
    that pretty much sucks, second problem is that
    barbicanclient as of version 3.0.0.0 no longer
    has an "auth" module, as a result Cinderunit tests
    now fail.

    The test_barbican.py unit tests need to be rewritten
    to mock out the client components and actually test
    Cinder components where needed without relying on
    the barbicanclient.

    For now in order to free up the gate, remove test_barbican.py

    Change-Id: Id770c87c0d622ae4c1e0d71141ffa9aed29be2ec
    Partial-Bug: #1389419
    (cherry picked from commit 37e4a12652c803d60c18079b735d96e5c7890f07)

tags: added: in-stable-juno
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers