commit 182e071a113fef7138a77bfae0d3b432e875d289
Author: Zoltan Arnold Nagy <email address hidden>
Date: Wed Feb 12 23:01:10 2014 +0100
Fix FC connection handling in the storwize driver
Creating FC connections was not working due to several issues:
1. The lsfabric command in the Storwize/SVC omitted the delimeter and so
the output was not correctly parsed by the driver.
2. In some cases comparisons of WWPNs were not case insensitive - ensure
we compare lower-case WWPNs.
3. If the host supplied extra information in the connector (e.g. iSCSI
initiator name in case of an FC setup, or FC WWNNs/WWPNs in an iSCSI
setup), the driver would try to make those host mappings on the storage
too. This could lead into unwanted behaviour and confusing error
messages (for example, in an FC setup reaching the maximum number of
iSCSI mappings).
In addition, unit tests weren't properly testing FC - instead they were
always testing iSCSI due to an error in parsing extra_specs. This patch
fixes that error and the unit tests as well.
These changes must all be made together for unit tests to pass.
Reviewed: https:/ /review. openstack. org/73077 /git.openstack. org/cgit/ openstack/ cinder/ commit/ ?id=182e071a113 fef7138a77bfae0 d3b432e875d289
Committed: https:/
Submitter: Jenkins
Branch: master
commit 182e071a113fef7 138a77bfae0d3b4 32e875d289
Author: Zoltan Arnold Nagy <email address hidden>
Date: Wed Feb 12 23:01:10 2014 +0100
Fix FC connection handling in the storwize driver
Creating FC connections was not working due to several issues:
1. The lsfabric command in the Storwize/SVC omitted the delimeter and so
the output was not correctly parsed by the driver.
2. In some cases comparisons of WWPNs were not case insensitive - ensure
we compare lower-case WWPNs.
3. If the host supplied extra information in the connector (e.g. iSCSI
initiator name in case of an FC setup, or FC WWNNs/WWPNs in an iSCSI
setup), the driver would try to make those host mappings on the storage
too. This could lead into unwanted behaviour and confusing error
messages (for example, in an FC setup reaching the maximum number of
iSCSI mappings).
In addition, unit tests weren't properly testing FC - instead they were
always testing iSCSI due to an error in parsing extra_specs. This patch
fixes that error and the unit tests as well.
These changes must all be made together for unit tests to pass.
Closes-bug: 1279758 f5bfd52ce2644f6 f229bcc69dc
Change-Id: I64e21609ba089c