Storwize/SVC: delim not passed to lsfabric

Bug #1279758 reported by Avishay Traeger on 2014-02-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Critical
Li Min Liu

Bug Description

The delimiter which is expected to be passed in all SSH requests that return information is missing from the 'lsfabric' command. This prevents FC connections.

Fix proposed to branch: master
Review: https://review.openstack.org/73266

Changed in cinder:
status: New → In Progress
Changed in cinder:
assignee: Avishay Traeger (avishay-il) → Li Min Liu (liminliu)
Li Min Liu (liminliu) wrote :

hi, Avishay:
Is this the same as https://review.openstack.org/#/c/73077/?

Avishay Traeger (avishay-il) wrote :

Li Min: Yes

Reviewed: https://review.openstack.org/73077
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=182e071a113fef7138a77bfae0d3b432e875d289
Submitter: Jenkins
Branch: master

commit 182e071a113fef7138a77bfae0d3b432e875d289
Author: Zoltan Arnold Nagy <email address hidden>
Date: Wed Feb 12 23:01:10 2014 +0100

    Fix FC connection handling in the storwize driver

    Creating FC connections was not working due to several issues:

    1. The lsfabric command in the Storwize/SVC omitted the delimeter and so
    the output was not correctly parsed by the driver.
    2. In some cases comparisons of WWPNs were not case insensitive - ensure
    we compare lower-case WWPNs.
    3. If the host supplied extra information in the connector (e.g. iSCSI
    initiator name in case of an FC setup, or FC WWNNs/WWPNs in an iSCSI
    setup), the driver would try to make those host mappings on the storage
    too. This could lead into unwanted behaviour and confusing error
    messages (for example, in an FC setup reaching the maximum number of
    iSCSI mappings).

    In addition, unit tests weren't properly testing FC - instead they were
    always testing iSCSI due to an error in parsing extra_specs. This patch
    fixes that error and the unit tests as well.

    These changes must all be made together for unit tests to pass.

    Closes-bug: 1279758
    Change-Id: I64e21609ba089cf5bfd52ce2644f6f229bcc69dc

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-03-05
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-04-17
Changed in cinder:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers