Comment 4 for bug 996361

Revision history for this message
Juan L. Negron (negronjl) wrote :

Hello:

Thank you for the update. Here is my feedback:
- The server relation with the yacy interface should have a hook. It currently doesn't.
- Could you augment the README file with more information about the charm? How to use it? What it does, etc.?
- I see a syntax error in the start hook ( start yacy should probably be service start yacy )
- The same as above applies to the stop hook ( stop yacy should probably be service stop yacy ).

I would be happy to review this again after you get a chance to address these.

-Juan