Charm needed: Yacy

Bug #996361 reported by Alan Pope 🍺🐧🐱 πŸ¦„ on 2012-05-08
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juju Charms Collection
Undecided
Alan Pope 🍺🐧🐱 πŸ¦„

Bug Description

Yacy is a popular peer-to-peer search and index system.

Changed in charms:
assignee: nobody → Alan Pope (popey)
Changed in charms:
status: New → In Progress
Changed in charms:
status: In Progress → Fix Committed
Marco Ceppi (marcoceppi) wrote :

Hi Alan!

Great first start for this Yacy charm! There are a few blockers that would need to be addressed before it can be submitted to the charm store.

= Blockers =

hooks/install
-----------------
All files that are lent to the installation of software (in this case the asc file for apt-key) need to be securely pulled or cryptographically checked. Since yacy doesn't provide an SSL certificate it's best to download the file yourself (and verify it's the correct key) then include it in the charm.

hooks/upgrade-charm
------------------------------
The current upgrade hook is called "upgrade" instead of "upgrade-charm" a rename will resolve this

hooks/config-changed
-------------------------------
The current configuration hook is in the root of the charm and not in the hooks folder. You'll need to move it in to the hooks folder and make it executable

COPYRIGHT
----------------
Every charm requires a copyright file, and for the charm to be licensed under an "Open" license. We recommend GPLv3 but any of the licenses under http://www.opensource.org/licenses/ are acceptable.

= Nitpicks and non-blockers =

metadata.yaml
--------------------
revision is depreciated in the metadata.yaml file (it's tracked in the revision file instead) as such the revision key should be removed from metadata.yaml

hooks/server-relation-*
--------------------------------
You specify that server is a relation that the charm provides, but there are no hooks for this relation. A hook will need to be created to accommodate this relation

Changed in charms:
status: Fix Committed → Incomplete
Marco Ceppi (marcoceppi) wrote :

Also, just realized, could you push your work to lp:~popey/charms/precise/yacy/trunk as it's the naming scheme used for personal charm branches (lp:~USER/charms/SERIES/CHARM/trunk)

I have fixed all bar the last nitpick I believe, and have pushed to lp:~popey/charms/precise/yacy/trunk and linked above. Thanks.

Changed in charms:
status: Incomplete → Fix Committed
Juan L. Negron (negronjl) wrote :

Hello:

Thank you for the update. Here is my feedback:
- The server relation with the yacy interface should have a hook. It currently doesn't.
- Could you augment the README file with more information about the charm? How to use it? What it does, etc.?
- I see a syntax error in the start hook ( start yacy should probably be service start yacy )
- The same as above applies to the stop hook ( stop yacy should probably be service stop yacy ).

I would be happy to review this again after you get a chance to address these.

-Juan

Changed in charms:
status: Fix Committed → Incomplete

Thanks for the feedback. I think I've done all that's required.

Changed in charms:
status: Incomplete → Fix Committed

I've reverted the change you recommended Juan because it broke the charm. "start yacy" and "stop yacy" work fine, "service start yacy" and "service stop yacy" do not because these aren't upstart jobs.

Jorge Castro (jorge) on 2012-05-22
tags: removed: new-charm
Juan L. Negron (negronjl) wrote :

Hi Alan:

There have been some changes since I last reviewed this charm:
- Charm should have a maintainer entry in the metadata.yaml file ... yours would look like:
maintainer: Alan Pope <email address hidden>

- You should also consider providing something ( maybe http? )

- The service doesn't start ( start-error )
  The problem seems to be in "start yacy" ... you should consider using "service yacy start"
  The same applies to the stop hook.

I can review the charm once the changes have been completed ... Just re-set the charm to Fix Committed.

-Juan

Changed in charms:
status: Fix Committed → Incomplete
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers