© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Greetings Chris,
First and foremost, thank you for the submission of the phplist charm! I took an opportunity to review your code and I have the following comments:
# Charm Proof
When i executed charm proof from the `charm tools` package, it came back with the following errors:
E: Charm must have either a maintainer or maintainers field
W: Metadata is missing categories.
W: No icon.svg file.
W: config.yaml: option bounce-email does not have the keys: default
W: config.yaml: option bounce-email has unknown keys: defualt
According to charm-store policy, anything above a W: is a blocking issue for promulgation. These will need to be fixed before we can consider pushing the charm to the charm store.
The Readme is a little light on details. If you have the charm-tools package installed, you can issue 'charm add readme` and populate the fields appropriately with details about the charms deployment, scaling options, configurtion options, and upstream support details.
I gave the code a cursory review, but have not deployed the service. I see no obvious blockers in the code review portion.
You are very close to being accepted to the charm store, if you could correct the issues outlined above and resubmit someone will be along shortly to review your work. Thank you again for the submission, and your patience during the review process
I'm going to change status of this bug to "incomplete" and when you're ready for another review please change the status to "fix submitted".
If you have any questions/