New Charm: phpList

[Chris Hardee]

https://code.launchpad.net/~shazzner/charms/precise/phplist/trunk

Charm for php-based email marketing server phpList

[Marco Ceppi (marcoceppi)]

Hi Chris, sorry for the delayed response, is this ready for review?

[Chris Hardee (shazzner)]

Holy moly, that's a delayed response! I have no idea, haven't seen the code
in almost two years haha

On Sun, Dec 1, 2013 at 8:36 PM, Marco Ceppi <email address hidden> wrote:

> Hi Chris, sorry for the delayed response, is this ready for review?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/971784
>
> Title:
> New Charm: phpList
>
> Status in Juju Charms:
> New
>
> Bug description:
> https://code.launchpad.net/~shazzner/charms/precise/phplist/trunk
>
> Charm for php-based email marketing server phpList
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charms/+bug/971784/+subscriptions
>

--
Chris Hardee
10BitWorks
San Antonio Hackerspace
<email address hidden>
http://10bitworks.com/

[Charles Butler (lazypower)]

Greetings Chris,

First and foremost, thank you for the submission of the phplist charm! I took an opportunity to review your code and I have the following comments:

# Charm Proof

When i executed charm proof from the `charm tools` package, it came back with the following errors:

E: Charm must have either a maintainer or maintainers field
W: Metadata is missing categories.
W: No icon.svg file.
W: config.yaml: option bounce-email does not have the keys: default
W: config.yaml: option bounce-email has unknown keys: defualt

According to charm-store policy, anything above a W: is a blocking issue for promulgation. These will need to be fixed before we can consider pushing the charm to the charm store.

The Readme is a little light on details. If you have the charm-tools package installed, you can issue 'charm add readme` and populate the fields appropriately with details about the charms deployment, scaling options, configurtion options, and upstream support details.

I gave the code a cursory review, but have not deployed the service. I see no obvious blockers in the code review portion.

You are very close to being accepted to the charm store, if you could correct the issues outlined above and resubmit someone will be along shortly to review your work. Thank you again for the submission, and your patience during the review process

 I'm going to change status of this bug to "incomplete" and when you're ready for another review please change the status to "fix submitted".

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

[Launchpad Janitor (janitor)]

[Expired for Juju Charms Collection because there has been no activity for 60 days.]