Hi Nathan! Thanks again for working on charms, this is another cool one. :)
Many of the same things from the pastebin/lodgeit review apply. Just little nit-picks before it can be a part of the official repository.
-- Blockers --
[1] Need a copyright file
[2] Broken website relation
Make sure to send the required elements of this relation (hostname, and port). See the review on lodgeit/pastebin for an example.
-- Non Blockers --
[3] open-port before database?
Is the app functional without the database configuration? If not, do not open-port until after you have written out the database configuration. That way external users won't be exposed to a broken service.
Hi Nathan! Thanks again for working on charms, this is another cool one. :)
Many of the same things from the pastebin/lodgeit review apply. Just little nit-picks before it can be a part of the official repository.
-- Blockers --
[1] Need a copyright file
[2] Broken website relation
Make sure to send the required elements of this relation (hostname, and port). See the review on lodgeit/pastebin for an example.
-- Non Blockers --
[3] open-port before database?
Is the app functional without the database configuration? If not, do not open-port until after you have written out the database configuration. That way external users won't be exposed to a broken service.