Charm needed: Stack Mobile
Bug #940677 reported by
Jorge Castro
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Juju Charms Collection |
Fix Released
|
High
|
Nathan Osman | ||
Related branches
lp:~george-edison55/charms/oneiric/stackmobile/trunk
- Marco Ceppi (community): Approve
-
Diff: 46 lines (+19/-2)3 files modifiedREADME (+17/-0)
hooks/install (+1/-1)
hooks/stop (+1/-1)
| Changed in charms: | |
| assignee: | nobody → Nathan Osman (george-edison55) |
| tags: | added: new-charm |
Revision history for this message
| Clint Byrum (clint-fewbar) wrote | #1 |
| Changed in charms: | |
| status: | New → Incomplete |
| importance: | Undecided → High |
| Changed in charms: | |
| status: | Incomplete → Confirmed |
Revision history for this message
| Nathan Osman (george-edison55) wrote | #2 |
Revision history for this message
| Clint Byrum (clint-fewbar) wrote | #3 |
| Changed in charms: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
Hi Nathan! Thanks again for working on charms, this is another cool one. :)
Many of the same things from the pastebin/lodgeit review apply. Just little nit-picks before it can be a part of the official repository.
-- Blockers --
[1] Need a copyright file
[2] Broken website relation
Make sure to send the required elements of this relation (hostname, and port). See the review on lodgeit/pastebin for an example.
-- Non Blockers --
[3] open-port before database?
Is the app functional without the database configuration? If not, do not open-port until after you have written out the database configuration. That way external users won't be exposed to a broken service.