Comment 6 for bug 1441622
Revision history for this message
| amir sanjar (asanjar) wrote Re: Review queue: xCAT | #6 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks for your contributions to the Juju Charm community. Few comments:
1) Missing tests
2) Immutable config: After deploying without a valid XCAT_DOMAIN config value, changing that value doesn’t fix the domain and put the charm in a working state, because the config-changed hook is not implemented.
3) Missing implementation of http relation