Review queue: IBM xCAT
Bug #1441622 reported by
Johnny Shieh
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Juju Charms Collection |
Triaged
|
Undecided
|
Unassigned |
Bug Description
Hello Team,
Here is the IBM xCAT charm for review.
Deployable ibm-xcat layered charm can be found in the below repository.
Deployable Charm Repo: https:/
And, its source code can be found in the below repository.
Source Code Repo: https:/
Below is the charm store link and its revision
Link: https:/
Revision: cs:~ibmcharmers
Thanks
Related branches
lp:~jshieh/charms/trusty/xcat/1428813
- Michael Chase-Salerno: Approve
-
Diff: 11 lines (+1/-1)1 file modifiedREADME (+1/-1)
Changed in charms: | |
status: | Incomplete → Fix Committed |
Changed in charms: | |
status: | Incomplete → Fix Committed |
summary: |
- Review queue: xCAT + Review queue: IBM xCAT |
description: | updated |
Changed in charms: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
@Johnny,
Thanks for your contributions to the Juju Charm community. Adding xCAT as a cluster toolkit to the Charm catalog will give HPC users access to the rich Juju environment of deploy, connect, and scale.
--- General feedback ---
- no icon
- proof passes with no warning
- rename README to README.md for proper markdown parsing.
--- README ---
- Rephrase to be a bit more clear. Perhaps cut "partially."
>The partially installation steps follow the instructions given in the Sourceforget.net documentation:
Suggest singular for "charms" in this context:
>After the deployment, the user should expose the xCAT charms via:
- Add a space and indention to you override.yaml example to have it rendered as code.
- Nice touch on the giving an example override.yaml example.
- Appendix is nice with additional upstream information.
- The known limitations and issues well documented.
--- config.yaml ---
- What are the options for XCAT_REPO? Suggest to list some alternate examples in the config.yaml description as well as in the README.
- Would there be any issue of putting the default XCAT_DOMAIN to say, "test" in order to avoid the failure noted in the limitations sections? Perhaps make a default for XCAT_DOMAIN, and explicitly call out in the README that this value should be changed, but a default is in needed in order to avoid deployment issues on a stock deploy. This seemed to work in my testing, less error'ing on locating the .deb at SourceForge.
-- Deploy --
- Testing on local with a default domain value of "test" I get the following error sourceforge. net/projects/ xcat/files/ ubuntu/ xcat-dep/ pool/main/ x/xnba- undi/xnba- undi_1. 0.3-7_all. deb 404 Not Found
>unit-xcat-0: 2015-04-15 21:41:21 INFO install E: Failed to fetch http://
- Looking for this file at Sourceforge I indeed get a 404, as Sourgeforge returns: xcat-dep/ poo..2015032301 06_all. deb" file could not be found or is not available. Please select another file.
>The "/ubuntu/
--- Summary ---
This is a very good first revision of the charm. As you noted in the post installations instructions I think we could also add some additional config and relations to the charm in order to make this a more robust xcat deployment. As for the current charm submitted it does need to add an icon, update the readme, details for the source config option, and resolve the 404 .deb from SourceForge.
These are relatively small fixes and less the 404 I have proposed these fixes for your review, at your convenience at: /code.launchpad .net/~a. rosales/ charms/ trusty/ xcat/initial- review/ +merge/ 256403
https:/
I will put the status of this bug in "Incomplete" while you resolve the above issues. Please update the status to "Fix Commited" when you are ready for another review.
Thanks again for your contribution and feel free to reach out to us in IRC (#juju@freenode) or on the Juju mailing list if you have any questions.
-thanks,
Antonio