Juju Charms Collection

  1. Bug #1441622
  2. Comment #3

Comment 3 for bug 1441622

Revision history for this message
Johnny Shieh (jshieh) wrote : Re: Review queue: xCAT

Sorry, hit submit too quickly.
Here we go again:
1. Icon - there is an icon.svg file. I downloaded icon.svg from trunk and took a screenshot. Please look at attachment called icon.png

2. renamed README to README.md

3. Reworded "partially installation" with "initial installation"

4. corrected "charms" to charm

5. added space and tabs to example yaml fragment in README.md

6. I would prefer not to list example, alternative repositories. That's up to the user, who may have a preference themselves.

7. I originally was going to put in a default domain, something like: "default_domain.com". The problem with that, is that by having a default domain, it tricks xCAT into thinking everything is fine. I'd rather have a blank domain so that the user is forced to name a domain OR that the charm fails to install off the bat since there is no defined domain. Once you install with a wrong or fake domain, it is a pain to fix it in an installed xCAT and get the value reset.

8. I clicked on the link you mentioned and it is up and running. I took a screenshot of it. This happens with sourceforge.net. One known problem is that they are the recipient of malicious traffic diversion, which results in a DOS attack. Screenshot attached as: sourceforge.png