Comment 7 for bug 1401774

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

I've made two small adjustments to the charm

=== modified file 'metadata.yaml'
--- metadata.yaml 2013-08-15 03:32:22 +0000
+++ metadata.yaml 2015-09-30 16:19:27 +0000
@@ -2,5 +2,5 @@
 maintainer: Brad Marshall <email address hidden>
 summary: Bip
 description: "multiuser irc proxy with conversation replay and more"
-categories:
- - misc
+tags:
+ - chat

=== modified file 'tests/10-deploy'
--- tests/10-deploy 2014-11-10 05:44:23 +0000
+++ tests/10-deploy 2015-09-30 16:21:31 +0000
@@ -20,7 +20,7 @@
         except:
             raise

- cls.unit = cls.deployment.sentry.unit['bip/0']
+ cls.unit = cls.deployment.sentry['bip'][0]
         cls.ipaddr = cls.unit.info['public-address']
         cls.ports = cls.unit.info['open-ports']

The first addresses the move of categories to tags and the second is a cleaner way to get the first unit of bip without hardcoding the value. Bundletester shows working tests

bip
    charm-proof PASS
    00-setup PASS
    10-deploy PASS

PASS: 3 Total: 3 (85.421953 sec)

That with the updated README means it'll find it's way into the charmstore within the next hour. Thank you for your contribution!