Add bip charm to trusty

[Brad Marshall]

Please add the bip charm to trusty, I've tested it locally and it seems fine. It also has working tests to validate things are working properly.

See lp:~brad-marshall/charms/trusty/bip/trunk for the latest version.

[Whit Morriss (whitmo)]

Brad,

Thanks for your work on this charm. Looks good, has tests which pass, code is nice and clean, deploys great.

 LGTM +1 for promulgation.

Going forward with this charm, I have a few suggestions:

 - Basic use description in the README (how would connect my irc client, use config options, etc)
 - logging relationships (elk?)
 - unit tests for the python

[Brad Marshall (brad-marshall)]

Ok, sounds good. What's required to get the charm into trusty
right now?

I'm looking at rewriting it in the services framework, I have a
mostly complete version of it ready for review at
lp:~brad-marshall/charms/trusty/bip/services-framework that
just needs some final testing done to it.

The rest of the ideas sound good, I'll look at those in the future.

[Brad Marshall (brad-marshall)]

I've done an update on the readme to explain what the config variables are for, and examples of how to connect to bip once its up and running. The branch is at lp:~brad-marshall/charms/trusty/bip/update-readme. Once the charm has actually landed I can submit a MP for this readme into it, or would you prefer I update this MP?

[amir sanjar (asanjar)]

Hi Brad,

Thanks for your update to this charm. Looks good.
Just a suggestions, add charm & juju contact information to the README.md
example of information added to hadoop charms REAME.md:
## Contact Information
[<email address hidden>](mailto:<email address hidden>)
Amir Sanjar <email address hidden>
## Help
- [Juju mailing list](https://lists.ubuntu.com/mailman/listinfo/juju)
- [Juju community](https://jujucharms.com/community)

[José Antonio Rey (jose)]

Hello, Brad!

I've done a review of the bip charm for trusty. Let's get started!

# Overview

I took a quick look at the charm and, at a first glance, I just notice that there's a default username and password. This could be a security risk, since it's publicly available. Do you think it's possible to make the charm configuration fail in case there's no username/password, and then retry once it gets one? Anyways, let's get this deployed both with Amulet and manually.

# Deployment (manual)

I did the deployment as specified on the README.md file and had absolutely no problems. It installed fine, and I could connect over my IRC client.

# Deployment (CI-like)

I ran the tests using bundletester and passed successfully, no errors.

# Others

As Amir pointed out, it would be nice if the README.md file was expanded a bit more. If I didn't know what bip was, I wouldn't understand what the charm was for. Apart from that, everything looks to be ready for promulgation.

# Conclusion

Thanks for working on the bip charm, Brad! I hope to see the next iteration of the bip charm really soon. If you fix what I suggested earlier, I believe it would be ready to go to the store.

I will move the status of this bug to "Incomplete". Please, move it to either "New" or "Fix Committed" once the charm is ready for review again. Thanks again for submitting the charm!

[Brad Marshall (brad-marshall)]

I've updated the readme to more clearly explain how to use the charm. Please let me know what else is required to get this into the charm store.

[Marco Ceppi (marcoceppi)]

I've made two small adjustments to the charm

=== modified file 'metadata.yaml'
--- metadata.yaml 2013-08-15 03:32:22 +0000
+++ metadata.yaml 2015-09-30 16:19:27 +0000
@@ -2,5 +2,5 @@
 maintainer: Brad Marshall <email address hidden>
 summary: Bip
 description: "multiuser irc proxy with conversation replay and more"
-categories:
- - misc
+tags:
+ - chat

=== modified file 'tests/10-deploy'
--- tests/10-deploy 2014-11-10 05:44:23 +0000
+++ tests/10-deploy 2015-09-30 16:21:31 +0000
@@ -20,7 +20,7 @@
         except:
             raise

- cls.unit = cls.deployment.sentry.unit['bip/0']
+ cls.unit = cls.deployment.sentry['bip'][0]
         cls.ipaddr = cls.unit.info['public-address']
         cls.ports = cls.unit.info['open-ports']

The first addresses the move of categories to tags and the second is a cleaner way to get the first unit of bip without hardcoding the value. Bundletester shows working tests

bip
    charm-proof PASS
    00-setup PASS
    10-deploy PASS

PASS: 3 Total: 3 (85.421953 sec)

That with the updated README means it'll find it's way into the charmstore within the next hour. Thank you for your contribution!