Juju Charms Collection

  1. Bug #1401774
  2. Comment #1

Comment 1 for bug 1401774

Revision history for this message
Whit Morriss (whitmo) wrote :

Brad,

Thanks for your work on this charm. Looks good, has tests which pass, code is nice and clean, deploys great.

 LGTM +1 for promulgation.

Going forward with this charm, I have a few suggestions:

 - Basic use description in the README (how would connect my irc client, use config options, etc)
 - logging relationships (elk?)
 - unit tests for the python