Comment 1 for bug 1331844

Hi José!

Nice charm, thanks for submitting this! Only a few issues:

Bug:

- When using `juju set` to change the port, it looks like the new port gets written to the .port file, but the service doesn't get restarted, so the effective port does not actually change. I didn't look into why this is the case.

Suggestions:

- In the README section on scale out, it would be nice to add `juju deploy haproxy` before the add-relation, just to be super explicit and user-friendly.

- When you clone the pubphoto git repo in the install hook, it may be wise to specify the revision explicitly. Otherwise, future revisions may break your sed replacements (if line numbers and/or default ports change). Another option would be to fork the repo and make your revisions in the repo directly, making the sed replacements unnecessary.

If you could make these revisions I think this charm will be ready for the store. Thanks for another nice contribution!

Tim