New charm: pubphoto

[José Antonio Rey]

This is the submission for the new pubphoto charm.

PubPhoto is a service which allows you to share photos you can take or have on your camera roll instantly by accessing a webpage, and then sharing a code with the person you want the photo to be downloaded by. Simple, no hassles, no extra features needed, just an Internet connection.

[Tim Van Steenburgh (tvansteenburgh)]

Hi José!

Nice charm, thanks for submitting this! Only a few issues:

Bug:

- When using `juju set` to change the port, it looks like the new port gets written to the .port file, but the service doesn't get restarted, so the effective port does not actually change. I didn't look into why this is the case.

Suggestions:

- In the README section on scale out, it would be nice to add `juju deploy haproxy` before the add-relation, just to be super explicit and user-friendly.

- When you clone the pubphoto git repo in the install hook, it may be wise to specify the revision explicitly. Otherwise, future revisions may break your sed replacements (if line numbers and/or default ports change). Another option would be to fork the repo and make your revisions in the repo directly, making the sed replacements unnecessary.

If you could make these revisions I think this charm will be ready for the store. Thanks for another nice contribution!

Tim

[José Antonio Rey (jose)]

Ready for review!

[Whit Morriss (whitmo)]

Jose! thank you for this charm. Nice to see the fixes committed.

As we have gotten automated testing for charms stoodup, we are going to start requiring tests for all new charms, ragardless of series (rather than just for trusty or better).

Would you mind adding a simple smoketest for pubphoto?

-w

[José Antonio Rey (jose)]

Hey Whit,

Sorry for the delay, but tests have now been added to pubphoto! They deploy the service and verify that it is actually running on the address provided by the unit.

[Cory Johns (johnsca)]

José,

Thanks for adding the tests, they look great and everything passes. +1 for this to the store.

[Matt Bruzek (mbruzek)]

José,

Thanks for the submission of this charm. I am REALLY happy that you added tests! This will help our automated testing efforts and makes reviews go so much faster! Also thank you for working with me on IRC to clear up the questions I had.

I ran this charm with bundletester and all the tests passed! I have pushed this to the charm store as a recommended charm. Thanks again for the submission!