Comment 1 for bug 1294977

Greetings Cisco Team,

Thank you for the charm submission! This is a very interesting product, and an excellent first draft charm. I've performed a cursory review and have the following notes:

When deploying the actual charm, I wasn't able to complete a deployment as there was no set -e flag at the top, which we require at minimum for bash charms to prevent runaway charms when it encounters an error. We really recommend set -eux for any bash hooks.

The installation hook was unable to install vxgw with the following output:
The following NEW packages will be installed:
  vxgw
0 upgraded, 1 newly installed, 0 to remove and 5 not upgraded.
Need to get 99.4 MB of archives.
After this operation, 116 MB of additional disk space will be used.
WARNING: The following packages cannot be authenticated!
  vxgw
E: There are problems and -y was used without --force-yes

and additional bash syntax errors followed on line 66, hooks/install: line 66: [: : integer expression expected

This is a good first cut of the charm and barring some modifications you will be ready for another review in no time. Thank you for the submission and I look forward to seeing the next revision. If you have any questions about this review feel free to reply to this bug, join us in #juju on irc.freenode.net, or contact us via the mailing list <email address hidden>

I'm going to mark the status of the bug as incomplete, and when you are ready for another review simply move the status to "fix committed" and someone will be along shortly to review your changes. Thanks again!