Progress on Cisco N1KV vxlan-gateway charm first submission (cwchang)

[ChingWei Chang]

lp:~cwchang/charms/precise/vxlan-gateway/trunk
This is the initial submit for vxlan-gateway charm

[Charles Butler (lazypower)]

Greetings Cisco Team,

Thank you for the charm submission! This is a very interesting product, and an excellent first draft charm. I've performed a cursory review and have the following notes:

When deploying the actual charm, I wasn't able to complete a deployment as there was no set -e flag at the top, which we require at minimum for bash charms to prevent runaway charms when it encounters an error. We really recommend set -eux for any bash hooks.

The installation hook was unable to install vxgw with the following output:
The following NEW packages will be installed:
  vxgw
0 upgraded, 1 newly installed, 0 to remove and 5 not upgraded.
Need to get 99.4 MB of archives.
After this operation, 116 MB of additional disk space will be used.
WARNING: The following packages cannot be authenticated!
  vxgw
E: There are problems and -y was used without --force-yes

and additional bash syntax errors followed on line 66, hooks/install: line 66: [: : integer expression expected

This is a good first cut of the charm and barring some modifications you will be ready for another review in no time. Thank you for the submission and I look forward to seeing the next revision. If you have any questions about this review feel free to reply to this bug, join us in #juju on irc.freenode.net, or contact us via the mailing list <email address hidden>

I'm going to mark the status of the bug as incomplete, and when you are ready for another review simply move the status to "fix committed" and someone will be along shortly to review your changes. Thanks again!

[ChingWei Chang (cwchang)]

Charles,
I just pushed a new set of changes into lp:~springfield-team/charms/precise/vxlan-gateway/trunk for VXLAN Gateway.
In this new push, I did the following

1) ran "charm proof"
2) added "set -e" to each hooks vxlan-gateway has
3) changed icon.svg's background to gray 10% as you suggested in VEM's review.

As the README.md goes, this charm is a pretty simple subordinate charm of nova-cloud-controller. The juju deploy vxlan-gateway is only prepare image for nova-cli's VM instantiation.

When install hook is invoked, the image of vxlan-gateway is "apt-get install " to the system, which ends as a qcow2
image at nova cloud controller local folder /opt/cisco/n1kv/vxgw/. From this directory image is copied to glance repository for nova-cli to do the VM instantiation.

When stop is called, apt-get remove is used to remove the debian as well as the local folder one.

When upgrade-charm is invoked, the old Debian package will be removed and a new one will be put into the glance repo, similar to install hook.

You can look at installation guide at http://www.cisco.com/c/en/us/support/switches/nexus-1000v-kvm/products-installation-guides-list.html for more in-depths

ChingWei

[ChingWei Chang (cwchang)]

Hi,
I just want to see any status change w.r.t this review ? Nexus 1000V VSM and VEM are making good progress there.
ChingWei

[Charles Butler (lazypower)]

Thank you for the submission team,

I am acknowledging receipt of the submission. Someone will be along shortly to review the work. Thank you for your patience during the review process.

If you have any immediate questions/comments/concerns feel free to contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>

All the best

[ChingWei Chang (cwchang)]

Charles/reviewers.
By taking similar comment from VSM, I added in set -e for early error exit logic there in the latest push + icon.svg with gray 10% backgrond
Please let me know, thanks !

CW

[José Antonio Rey (jose)]

Hey team!

I did a quick check of the charm and I saw that the README file is not in Markdown. It would be great if the README file could be converted to Markdown so it can display properly in the Juju GUI.

Again, thanks a lot for your submission!

[ChingWei Chang (cwchang)]

Hi, Jose,
Thanks for that input. I used the juju charm add readme to create a template and transformed the old README.md to the conforming one.
Please see if it looks ok to you and charmers and help pull to charm store. (it's the last piece of Cisco proprietary charms)

ChingWei

[José Antonio Rey (jose)]

Hey!

README looks good on my side :)

Thank you for your efforts in the charm!

[Jorge Niedbalski (niedbalski)]

Hello guys,

I reviewed the charm and also i did wrote a base test deployment using amulet:

https://code.launchpad.net/~niedbalski/charms/precise/vxlan-gateway/add-tests/+merge/219364

Everything appears to be working correctly on my end, would be ideal to have this test suite skeleton
merged into the charm, but if not I suggest to promote this charm to the precise series.

Thanks.

[Marco Ceppi (marcoceppi)]

According to an IRC discussion this is no longer being engaged.