Comment 3 for bug 1293848

Greetings Wes,

Thank you for your submission to the charm store! I've deployed the Server Density agent, and I am pleased to report the following:

charm proof: no output! excellent, moving to the next phase.

Minor Knitpicks: The hooks are missing a set -e flag. This is the bare minimum for bash based scripts so they don't go rogue and halt on error, giving the user a chance to correct any misbehavior from the charm.

aside from that, everything looks to be in order. I had fun attaching the SD charm to deployed units, and continued to test the charm after its review phase was complete so I could get a better grasp of what the Server Density dash is giving us as a PAAS.

This is an excellent addition to the monitoring charms available in the store. With the only comment being such a minor knitpick I'm perfectly happy to sponsor this charm being accepted to the charm store. Its clear you've put in some excellent work here and I look forward to future iterations of the charm.

Thank you again for your submission!